Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static predicates in Whamm probes #226

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

matthew-mojira
Copy link
Contributor

No description provided.

@matthew-mojira matthew-mojira marked this pull request as draft November 20, 2024 21:42
src/util/Whamm.v3 Outdated Show resolved Hide resolved
src/monitors/WhammMonitor.v3 Outdated Show resolved Hide resolved
src/util/Whamm.v3 Show resolved Hide resolved
src/monitors/WhammMonitor.v3 Outdated Show resolved Hide resolved
src/monitors/WhammMonitor.v3 Outdated Show resolved Hide resolved
src/util/Whamm.v3 Outdated Show resolved Hide resolved
src/util/Whamm.v3 Outdated Show resolved Hide resolved
src/monitors/WhammMonitor.v3 Outdated Show resolved Hide resolved
Copy link
Owner

@titzer titzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@titzer titzer marked this pull request as ready for review November 21, 2024 23:38
@titzer
Copy link
Owner

titzer commented Nov 21, 2024

There's a conflict to be resolved, but otherwise I think we can merge this.

src/monitors/WhammMonitor.v3 Outdated Show resolved Hide resolved
src/monitors/WhammMonitor.v3 Outdated Show resolved Hide resolved
src/monitors/WhammMonitor.v3 Outdated Show resolved Hide resolved
@matthew-mojira
Copy link
Contributor Author

matthew-mojira commented Nov 22, 2024

should be ready for merge now...... or not

@matthew-mojira
Copy link
Contributor Author

This PR needs #228 to be merged first

@titzer
Copy link
Owner

titzer commented Nov 22, 2024

This PR needs #228 to be merged first

Looks like there are some other failed tests to address as well.

@titzer
Copy link
Owner

titzer commented Nov 26, 2024

There are still failing tests here. Can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants