Whamm intrinsification baseline (wasm to wasm call) #222
+154
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1539
to
+1541
| OUT.puts("JIT code: "); | ||
| masm.printCodeBytes(OUT); | ||
| OUT.ln(); |
There was a problem hiding this comment.
I think this makes debugging easier, since we can see the exact assembly generated for each opcode
thelongmarch-azx
changed the title
titzer
approved these changes
Nov 26, 2024
| @@ -106,6 +106,11 @@ component X86_64Runtime { | |||
| if (ret != null) return stack.throw(ret); | |||
| return ret; | |||
| } | |||
| def runtime_materialize_frame_accessor() { | |||
There was a problem hiding this comment.
How about calling this runtime_getFrameAccessorMetaRef()and returning the metaref, since it's needed by the caller?
|
|
||
| new(w, regConfig: RegConfig) super(Target.tagging, regConfig) { | ||
| scratch = G(regConfig.scratch); | ||
| } | ||
|
|
||
| def printCodeBytes(sb: StringBuilder) { |
There was a problem hiding this comment.
This adds a little more local state; how about keeping track of the offset of the bytecode start in the SPC? Partially because we should consider saving that for use at runtime, e.g. to compute the PC at frame walking instead of storing it as is done now.
| @@ -39,6 +39,13 @@ component Target { | |||
| if (Trace.compiler) { | |||
| Trace.OUT.put2("func[%d].target_code: break *0x%x", f.func_index, addr - Pointer.NULL) | |||
| .put2(" disass 0x%x, 0x%x", addr - Pointer.NULL, end - Pointer.NULL).ln(); | |||
| var cur_byte = addr; | |||
There was a problem hiding this comment.
How about guarding this behind a new trace flag --trace-asm?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.