Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simd/v3i]: Implement more integer arithmetic instructions #123

Merged
merged 6 commits into from
Oct 26, 2023

Conversation

haoyu-zc
Copy link
Contributor

Tested by:

make v3i -j && bin/spectest.v3i -tk test/regress/simd/simd_i64x2_arith2.bin.wast
make v3i -j && bin/spectest.v3i -tk test/regress/simd/simd_i32x4_arith2.bin.wast
make v3i -j && bin/spectest.v3i -tk test/regress/simd/simd_i16x8_arith2.bin.wast
make v3i -j && bin/spectest.v3i -tk test/regress/simd/simd_i8x16_arith2.bin.wast

Copy link
Owner

@titzer titzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with simplification suggestion

@titzer
Copy link
Owner

titzer commented Oct 25, 2023

Please not that I just moved around some utilities in V3Eval, so you'll need to rebase.

@haoyu-zc
Copy link
Contributor Author

Rebased accordingly. But I'm not sure which utilities should be modified by private since I noticed you removed some privates in your latest commit. For methods such as do_vv_v_x2, I think they should be private bc other files may not use them, right?

@titzer
Copy link
Owner

titzer commented Oct 26, 2023

Functions at the top level of a file (not in a class or a component) are private by default.

@@ -441,108 +498,259 @@ component V3Eval {
_ => return val;
}
}
}
// Private (i.e. file-scoped) utilities.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are outside the component, they don't need to be indented another level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I got it. Didn't notice they were moved outside of the component. Pushed a new change.

@titzer titzer merged commit b9133e8 into titzer:master Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants