-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[simd/v3i]: Implement more integer arithmetic instructions #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with simplification suggestion
Please not that I just moved around some utilities in |
a63ec21
to
9fac84b
Compare
Rebased accordingly. But I'm not sure which utilities should be modified by private since I noticed you removed some |
Functions at the top level of a file (not in a class or a component) are private by default. |
src/engine/V3Eval.v3
Outdated
@@ -441,108 +498,259 @@ component V3Eval { | |||
_ => return val; | |||
} | |||
} | |||
} | |||
// Private (i.e. file-scoped) utilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are outside the component, they don't need to be indented another level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I got it. Didn't notice they were moved outside of the component. Pushed a new change.
Tested by: