Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extism PDK #258

Merged
merged 13 commits into from
Jun 20, 2024
Merged

Add Extism PDK #258

merged 13 commits into from
Jun 20, 2024

Conversation

gmlewis
Copy link
Contributor

@gmlewis gmlewis commented Jun 19, 2024

This PR represents my attempt at writing an Extism PDK for the Virgil programming language.

As a Virgil newbie, I may not have done things in an idiomatic way, and am open to learning and recommendations on making this better.

apps/Extism/count-vowels/CountVowels.v3 Outdated Show resolved Hide resolved
apps/Extism/count-vowels/CountVowels.v3 Show resolved Hide resolved
apps/Extism/count-vowels/CountVowels.v3 Outdated Show resolved Hide resolved
lib/pdk/Header.v3 Outdated Show resolved Hide resolved
lib/pdk/Host.v3 Outdated Show resolved Hide resolved
lib/pdk/Http.v3 Outdated Show resolved Hide resolved
lib/pdk/Memory.v3 Outdated Show resolved Hide resolved
lib/pdk/Method.v3 Outdated Show resolved Hide resolved
lib/util/Map.v3 Outdated Show resolved Hide resolved
lib/util/Map.v3 Outdated Show resolved Hide resolved
@gmlewis
Copy link
Contributor Author

gmlewis commented Jun 19, 2024

Thank you for the feedback, @titzer !
I believe I have addressed it all.
Please take another look when you get a chance.

Copy link
Owner

@titzer titzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@titzer titzer merged commit 09ac5e2 into titzer:master Jun 20, 2024
7 checks passed
@gmlewis gmlewis deleted the extism-pdk branch June 20, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants