Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2583 Add exportword, importword and exportpdf JWT authentication guides for (PHP). #3519

Merged
merged 28 commits into from
Dec 11, 2024

Conversation

LewisAtTiny
Copy link

@LewisAtTiny LewisAtTiny commented Nov 26, 2024

Ticket: DOC-2583

Site: Export to PDF (PHP)
Site: Export to Word (PHP)
Site: Import from Word (PHP)

Changes:

  • Export to PDF with JWT authentication (PHP) Guide
  • Export to Word with JWT authentication (PHP) Guide
  • Import from Word with JWT authentication (PHP) Guide

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.
  • modules/ROOT/nav.adoc has been updated (if applicable).

Review:

  • Documentation Team Lead has reviewed

@LewisAtTiny LewisAtTiny changed the title Documentation for the JWT Authentication in relation to Document Exporters and Importers DOC-2583 Documentation for the JWT Authentication in relation to Document Exporters and Importers Nov 26, 2024
@kemister85
Copy link
Contributor

@LewisAtTiny Copy edit suggestion to PR title, so its more precise.

From:

DOC-2583 Documentation for the JWT Authentication in relation to Document Exporters and Importers

Update to:

DOC-2583: Add exportword, importword and exportpdf JWT authentication guides for (PHP).

@LewisAtTiny LewisAtTiny changed the title DOC-2583 Documentation for the JWT Authentication in relation to Document Exporters and Importers DOC-2583 Add exportword, importword and exportpdf JWT authentication guides for (PHP). Nov 27, 2024
Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy edits

modules/ROOT/nav.adoc Outdated Show resolved Hide resolved
modules/ROOT/nav.adoc Outdated Show resolved Hide resolved
modules/ROOT/nav.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LewisAtTiny Just some structure changes to match with the other guide, and minor copy edits.

Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @LewisAtTiny Well Done 🌟

Copy link

@soritaheng soritaheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guides are clear and easy to understand. Great job Lewis!

…ject-setup.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>
@kemister85 kemister85 merged commit 01db151 into tinymce/7 Dec 11, 2024
5 checks passed
@kemister85 kemister85 deleted the hotfix/7/DOC-2583 branch December 11, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants