Skip to content

Commit

Permalink
DOC-2578: TinyMCE 7.6.0 Release Documentation and Community Changelog. (
Browse files Browse the repository at this point in the history
#3513)

* DOC-2578: TinyMCE 7.6.0 Release Documentation and Community Changelog.

* DOC-2578: Pressing `Shift + Enter` in the comment textarea now selects the highlighted user. (#3522)

* DOC-2578: Pressing Shift + Enter in the comment textarea now selects the highlighted user.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2578: Moved content to the premium plugin area.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

---------

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2578: Changing the table row type when a `contentEditable="false"` cell was selected would not work as expected. (#3521)

* DOC-2578: Tooltip would not show for group toolbar button. (#3520)

* DOC-2578: Tooltip would not show for group toolbar button.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Farzad Hayat <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

---------

Co-authored-by: Farzad Hayat <[email protected]>
Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2578: Enhanced the accessibility checker color palette for better visual contrast and usability (#3532)

* DOC-2578: Scroll to show action buttons when replying/editing a comment. (#3523)

* DOC-2578: Scroll to show action buttons when replying/editing a comment.

* DOC-2578: Moved content to premium plugin section and reworded content to specify we only scroll in the scenario mentioned.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

---------

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2586: New disabled option for disabling all user interactions (#3527)

* DOC-2578: The mentions menu now expands freely to the available space outside of the editor. (#3533)

* DOC-2578: After creating a conversation, the focus goes to the newly … (#3540)

* DOC-2578: After creating a conversation, the focus goes to the newly created conversation

* DOC-2578: Mentioned some more scenarios where the issue occurred.

* DOC-2578: Rephrased content

* DOC-2578: Removed title attribute from dialog tree elements as they already have a tooltip. (#3526)

* DOC-2578: Removed title attribute from dialog tree elements as they already have a tooltip.

* Update 7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

---------

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2578: Fixed CSS Bundling for Skin UI Content CSS. (#3537)

* DOC-2578: Fixed CSS Bundling for Skin UI Content CSS.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: ltrouton <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: CODE:AG <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: CODE:AG <[email protected]>

---------

Co-authored-by: ltrouton <[email protected]>
Co-authored-by: CODE:AG <[email protected]>

* DOC-2578: Checklist items were unresponsive in center or right alignments. (#3542)

* DOC-2578: Adjust `tinycomments` UI font size to match the editor UI font size. (#3536)

* DOC-2578: Adjust tinycomments UI font size to match the editor UI font size.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Farzad Hayat <[email protected]>

---------

Co-authored-by: Farzad Hayat <[email protected]>

* DOC-2578: Enhanced accessibility checker UI to display affected content (#3541)

* DOC-2578: Enhanced accessibility checker UI to display affected content

* Update 7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

---------

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2578: The `commentAuthor` property is now included in reply events for the event log. (#3543)

* DOC-2578: The commentAuthor property is now included in reply events of the event log.

* Update modules/ROOT/partials/plugin-apis/comments-apis.adoc

* Update modules/ROOT/partials/plugin-apis/comments-apis.adoc

* Update modules/ROOT/partials/plugin-apis/comments-apis.adoc

* Update modules/ROOT/partials/plugin-apis/comments-apis.adoc

* Update modules/ROOT/partials/plugin-apis/comments-apis.adoc

* DOC-2578: Update callback demo to include commentAuthor.

* Update modules/ROOT/partials/configuration/tinycomments_reply.adoc

Co-authored-by: tiny-ben-tran <[email protected]>

---------

Co-authored-by: tiny-ben-tran <[email protected]>

* DOC-2578: Introduced a new live region for screen readers to improve accessibility notifications. (#3545)

* DOC-2578: Introduced a new live region for screen readers to improve accessibility notifications.

* DOC-2578: add write-up for ticket.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Arvin(Jintao) Han <[email protected]>

---------

Co-authored-by: Arvin(Jintao) Han <[email protected]>

* DOC-2578: Reduced the amount of scrolling when changing between conve… (#3544)

* DOC-2578: Reduced the amount of scrolling when changing between conversations in the sidebar.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

---------

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2578: Update changelog.adoc for TinyMCE 7.6.0.

* DOC-2578: Add Labels and Groups for Context Toolbar Buttons. (#3548)

* DOC-2578: Add Labels and Groups for Context Toolbar Buttons.

* Update antora.yml

* DOC-2578: Added placeholder support for context form input fields. (#3549)

* DOC-2578: Fixed Caret Position when closing Comment Mentions dropdown (#3525)

* DOC-2578: Fixed Caret Position when closing Comment Mentions dropdown TINY-11453

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

---------

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2578: Added tooltips to conversation and comment kebab menus. (#3546)

* DOC-2578: Spelling error in tooltip for  toggle button (#3547)

* DOC-2578: Spelling error in tooltip for  toggle button

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

---------

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2578: New `onSetup` function for context forms. (#3550)

* DOC-2578: New onSetup function for context forms.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

* DOC-2578: General cleanup and structure formatting pre-release.

* DOC-2578: New `back` function in `ContextFormApi` to go back to the previous toolbar. (#3558)

* DOC-2578: New back function in ContextFormApi to go back to the previous toolbar.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

* New QuickbarInsertImage command that is executed by the quickimage button. (#3557)

* Image selection was removed when calling nodeChanged while having focus inside the editor UI. (#3556)

* DOC-2578: Add known issue for missing translations.

* DOC-2578: Incorrect translation of  `Cut Column` and `Copy Column`  in Hebrew (#3559)

* DOC-2578: Incorrect translation of  and  in Hebrew

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

---------

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2578: Add new entry for Image Optimizer new plugin announcment.

* DOC-2578: Add entry for new premium plugin Image Optimizer in release notes.

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

* Update modules/ROOT/pages/changelog.adoc

* DOC-2578: Comment out improvements for various last min discovered tickets.

* DOC-2578: Comment out changelog title placeholders for post release fixes.

* Update modules/ROOT/pages/contexttoolbar.adoc

Co-authored-by: Farzad Hayat <[email protected]>

* Update modules/ROOT/pages/contextform.adoc

Co-authored-by: Farzad Hayat <[email protected]>

* Update modules/ROOT/pages/changelog.adoc

Co-authored-by: Farzad Hayat <[email protected]>

* Update modules/ROOT/pages/changelog.adoc

Co-authored-by: Farzad Hayat <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Farzad Hayat <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Farzad Hayat <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Farzad Hayat <[email protected]>

* Update modules/ROOT/partials/configuration/tinycomments_reply.adoc

Co-authored-by: tiny-ben-tran <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Farzad Hayat <[email protected]>

* Update modules/ROOT/pages/7.6.0-release-notes.adoc

Co-authored-by: Farzad Hayat <[email protected]>

---------

Co-authored-by: CODE:AG <[email protected]>
Co-authored-by: Farzad Hayat <[email protected]>
Co-authored-by: ltrouton <[email protected]>
Co-authored-by: tiny-ben-tran <[email protected]>
Co-authored-by: Arvin(Jintao) Han <[email protected]>
  • Loading branch information
6 people authored Dec 11, 2024
1 parent 61fae0a commit e775358
Show file tree
Hide file tree
Showing 14 changed files with 485 additions and 99 deletions.
2 changes: 1 addition & 1 deletion antora.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ asciidoc:
# product variables
productname: TinyMCE
productmajorversion: 7
productminorversion: '7.5'
productminorversion: '7.6'
##### product name in codeblock
prodnamecode: tinymce
#### more names
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ const tinycomments_reply = (req, done, fail) => {
})
.then((req2) => {
const commentUid = req2.commentUid;
done({ commentUid });
done({
commentUid: replyUid,
author: currentUser.id,
authorName: currentUser.fullName
});
})
.catch((e) => {
fail(e);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<textarea id="context-toolbar-labels">
<p>Clicking on the example image below will show the newly configured context toolbar.</p>

{{logofordemoshtml}}

<p>Select a word in this sentence, to see the other newly configured context toolbar.</p>

<p>Clicking on text should not invoke the context toolbar</p>
</textarea>
34 changes: 34 additions & 0 deletions modules/ROOT/examples/live-demos/context-toolbar-labels/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
tinymce.init({
selector: 'textarea#context-toolbar-labels',
height: 350,
setup: (editor) => {
editor.ui.registry.addContextToolbar('imagealignment', {
predicate: (node) => node.nodeName.toLowerCase() === 'img',
position: 'node',
scope: 'node',
items: [
{
name: 'Formatting',
items: ['alignleft', 'aligncenter', 'alignright']
},
{
label: 'Copy',
items: ['copy', 'paste']
}
],
});

editor.ui.registry.addContextToolbar('textselection', {
predicate: (node) => !editor.selection.isCollapsed(),
position: 'selection',
scope: 'node',
items: [
{
name: 'Format',
items: ['bold', 'italic', 'underline']
},
],
});
},
content_style: 'body { font-family:Helvetica,Arial,sans-serif; font-size:16px }'
});
10 changes: 2 additions & 8 deletions modules/ROOT/nav.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -412,18 +412,12 @@
** xref:release-notes.adoc[Release notes for {productname}]
*** {productname} 7.6.0
**** xref:7.6.0-release-notes.adoc#overview[Overview]
**** xref:7.6.0-release-notes.adoc#new-premium-plugin<s>[New Premium plugin<s>]
**** xref:7.6.0-release-notes.adoc#new-open-source-plugin<s>[New Open Source plugin<s>]
**** xref:7.6.0-release-notes.adoc#new-premium-plugin[New Premium plugin]
**** xref:7.6.0-release-notes.adoc#accompanying-premium-plugin-changes[Accompanying Premium plugin changes]
**** xref:7.6.0-release-notes.adoc#accompanying-premium-plugin-end-of-life-announcement[Accompanying Premium plugin end-of-life announcement]
**** xref:7.6.0-release-notes.adoc#accompanying-open-source-plugin-end-of-life-announcement[Accompanying open source plugin end-of-life-announcement]
**** xref:7.6.0-release-notes.adoc#accompanying-enhanced-skins-and-icon-packs-changes[Accompanying Enhanced Skins & Icon Packs changes]
**** xref:7.6.0-release-notes.adoc#improvements[Improvements]
// **** xref:7.6.0-release-notes.adoc#improvements[Improvements]
**** xref:7.6.0-release-notes.adoc#additions[Additions]
**** xref:7.6.0-release-notes.adoc#changes[Changes]
**** xref:7.6.0-release-notes.adoc#bug-fixes[Bug fixes]
**** xref:7.6.0-release-notes.adoc#security-fixes[Security fixes]
**** xref:7.6.0-release-notes.adoc#deprecated[Deprecated]
**** xref:7.6.0-release-notes.adoc#known-issues[Known issues]
*** {productname} 7.5.1
**** xref:7.5.1-release-notes.adoc#overview[Overview]
Expand Down
398 changes: 314 additions & 84 deletions modules/ROOT/pages/7.6.0-release-notes.adoc

Large diffs are not rendered by default.

40 changes: 38 additions & 2 deletions modules/ROOT/pages/changelog.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,45 @@

NOTE: This is the {productname} Community version changelog. For information about the latest {cloudname} or {enterpriseversion} Release, see: xref:release-notes.adoc[{productname} Release Notes].

== xref:7.6.0-release-notes.adoc[7.6.0 - 2024-12-04]
== xref:7.6.0-release-notes.adoc[7.6.0 - 2024-12-11]

//TODO
=== Added
* It is now possible to create labeled groups in context toolbars.
// #TINY-11095
// * New `contextsliderform` and `contextsizeinput` context form types.
// #TINY-11342
* New `back` function in `ContextFormApi` to go back to the previous toolbar.
// #TINY-11344
* New `QuickbarInsertImage` command that is executed by the `quickimage` button.
// #TINY-11399
* New `onSetup` function to the context form API.
// #TINY-11494
* New `placeholder` to the context form input field API.
// #TINY-11459
* New `disabled` option to restore the previous `readonly` mode behavior, allowing the editor to be displayed in a disabled state.
// #TINY-11488

// === Improved
// * Base64 data was not properly decoded due to unhandled URL-encoded characters.
// #TINY-9548
// * The `latin` list style type is now recognized as an alias for the `alpha` list style type.
// #TINY-11515

=== Fixed
* Image selection was removed when calling `+editor.nodeChanged()+` while having focus inside the editor UI.
// #TINY-11437
* Tooltip would not show for group toolbar button.
// #TINY-11391
* Changing the table row type when a `+contenteditable=false+` cell was selected would not work as expected.
// #TINY-11383
// * The `samp` format was being applied as a `block` level format, instead of an `inline` format.
// #TINY-11390
* Removed title attribute from dialog tree elements as they already have a tooltip.
// #TINY-11470
* Fixed CSS bundling for skin UI content CSS.
// #TINY-11558
* Fixed incorrect resource keys for CSS bundling JS files.
// #TINY-11558

== xref:7.5-release-notes.adoc[7.5.0 - 2024-11-06]

Expand Down
8 changes: 7 additions & 1 deletion modules/ROOT/pages/contextform.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ This relates to the form itself. The form specifications are:
|`+position+` |This controls where the context toolbar will appear with regards to the current cursor.
|`+scope+` |This controls whether the predicate (condition) is a `+node+`-based predicate, or an `+editor+`-based predicate. See context toolbar priority for more details.
|`+commands+` |This is a list of the items to show in the context form. They can be either `+contextformbutton+` or `+contextformtogglebutton+`.
|`+onSetup+`
a|
`+(ContextFormApi) => (ContextFormApi) => void+`

Optional default: `+() => () => {}+` - Function that's executed when the form is rendered. Once rendered, it returns a function that is executed when the context form is closed.
|===

include::partial$context/positioning.adoc[leveloffset=+1]
Expand Down Expand Up @@ -100,12 +105,13 @@ Where the `+toggleButtonApi+` is the same as a regular toolbar toggle button.

=== formApi

Both `+contextformbutton+` and `+contextformtogglebutton+` are passed `+formApi+` in their `+onAction+` callback. The `+formApi+` has two functions:
Both `+contextformbutton+` and `+contextformtogglebutton+` are passed `+formApi+` in their `+onAction+` callback. The `+formApi+` has three functions:

[cols="1,3",options="header"]
|===
|Functions |Description
|`+hide+` |This will hide the form. By default, no button hides the form. It is the responsibility of the developer to hide the form in the `+onAction+` handler of buttons that require that the context form close after the action.
|`+back+` |This will restore the previous toolbar. This is useful when you want to go back to the previous toolbar when you press back in the toolbar.
|`+getValue+` |This will retrieve the value current typed in the input field.
|===

Expand Down
35 changes: 35 additions & 0 deletions modules/ROOT/pages/contexttoolbar.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,41 @@ This example shows how the quickbars plugin adds the standard selection context

liveDemo::context-toolbar[height="600", tab="js"]

[[add-labels-and-groups-for-context-toolbar-buttons]]
== Add labels and groups for context toolbar buttons

From {productname} 7.6.0 onward, registering a context toolbar allows specifying `items` as an object that supports grouping with optional names and labels. This improvement enhances toolbar usability by organizing buttons into titled or labeled groups.

The object structure takes two optional properties: `name` and `label`.

* `name`: property is used as the group's title for the group that contains the buttons.
* `label`: property is used as a label for each group of buttons.

[NOTE]
If neither `name` nor `label` are specified, the behavior defaults to ungrouped buttons.

The object structure for `items` is as follows:

.Example of a context toolbar configuration with groups and labels
[source,js]
----
items: [
{
name: 'Formatting', // Optional, used as the group's title
items: [ 'bold', 'italic' ] // Array of registered button names
},
{
label: 'History', // Optional, used as a label for the group
items: [ 'undo', 'redo' ] // Array of registered button names
},
{
items: [ 'undo', 'italic' ] // No name or label specified, default behavior applies
}
]
----

liveDemo::context-toolbar-labels[height="600", tab="js"]

== Launching a context toolbar programmatically

There is an `+editor+` event called `+contexttoolbar-show+` that can be fired to show a context toolbar at the current selection. The event takes a parameter `+toolbarKey+` which specifies the name of the registered context form or context toolbar to show.
Expand Down
4 changes: 4 additions & 0 deletions modules/ROOT/pages/editor-important-options.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ include::partial$configuration/external_plugins.adoc[leveloffset=+1]

include::partial$configuration/readonly.adoc[leveloffset=+1]

== Setting the editor in a disabled state

include::partial$configuration/disabled.adoc[leveloffset=+1]

== Executing custom functions while the editor starts (initializes)

include::partial$configuration/setup.adoc[leveloffset=+1]
Expand Down
1 change: 1 addition & 0 deletions modules/ROOT/pages/events.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ The following events are provided by the {productname} editor.
|ObjectResized |`+{ target: HTMLElement, width: number, height: number, origin: string }+` |Fired when an object (such as an image) has finished being resized.
|ObjectResizeStart |`+{ target: HTMLElement, width: number, height: number, origin: string }+` |Fired when an object (such as an image) is about to be resized.
|SwitchMode |`+{ mode: string }+` |Fired when the editor mode is changed. The available modes are "design" and "readonly". Additional modes can be registered using {productname} API xref:apis/tinymce.editormode.adoc#register['tinymce.activeEditor.mode.register()'].
|DisabledStateChange |+{ state: boolean }+ |Fired when the editor disabled mode state changes.
|ScrollWindow |(Same data as the native https://developer.mozilla.org/en-US/docs/Web/API/Element/scroll_event[scroll event]) |Fired when the window has scrolled.
|ResizeWindow |(Same data as the native https://developer.mozilla.org/en-US/docs/Web/API/Window/resize_event[resize event]) |Fired when the window is resized.
|BeforeExecCommand |`+{ command: string, ui?: boolean, value?: any }+` |Fired before a command is executed.
Expand Down
23 changes: 23 additions & 0 deletions modules/ROOT/partials/configuration/disabled.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
[[disabled]]

== `+disabled+`

Disables all user interactions with the editor (including cursor placement, content modifications, UI components). This option provides behavior similar to the changes made to {productname} in 7.4.0 readonly mode. When enabled, the editor becomes completely non-interactive.

To programmatically enable/disable the editor, use `+tinymce.activeEditor.options.set('disabled', false/true)+`.

*Type:* `+Boolean+`

*Default value:* `+false+`

*Possible values:* `+true+`, `+false+`

=== Example: using `+disabled+`

[source,js]
----
tinymce.init({
selector: 'textarea', // change this value according to your HTML
disabled: true
});
----
10 changes: 8 additions & 2 deletions modules/ROOT/partials/configuration/tinycomments_reply.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ The `+done+` callback should accept the following object:
[source,js]
----
{
commentUid: string // the value of the new comment uid
commentUid: string, // the new comment uid
author: string, // the id of the current author
authorName: string // the name of the current author
}
----

Expand All @@ -42,7 +44,11 @@ const reply_comment = (ref, done, fail) => {
})
.then((ref2) => {
let commentUid = ref2.commentUid;
done({ commentUid: commentUid });
done({
commentUid: replyUid,
author: currentUser.id,
authorName: currentUser.fullName
});
})
.catch((e) => {
fail(e);
Expand Down
4 changes: 4 additions & 0 deletions modules/ROOT/partials/plugin-apis/comments-apis.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ The `getEventLog` returns a log that contains information and timestamps of all
"conversationContent": "new comment (Edit comment)",
"conversationCreatedAt": "2024-10-01T03:07:53.771Z",
"commentContent": "reply to existing comment",
"commentAuthor": {
"author": "DEMO USER",
"authorName": "DEMO USER"
},
"conversationAuthor": {
"author": "DEMO USER",
"authorName": "DEMO USER"
Expand Down

0 comments on commit e775358

Please sign in to comment.