This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
Fix missing nav bar #179
Merged
Fix missing nav bar #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tinkerbell-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jacobweinstock
force-pushed
the
fix-menu
branch
from
e9b8c8b to
20eecd1
Compare
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
fix-menu
branch
from
20eecd1 to
6b3e84c
Compare
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
fix-menu
branch
from
3495481 to
b4e513a
Compare
Signed-off-by: Jacob Weinstock <[email protected]>
Netlify only supports up to python 3.8 Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
fix-menu
branch
from
d1c8c8b to
be658d6
Compare
Fix nav by copying from: https://github.com/squidfunk/mkdocs-material/blob/master/src/templates/partials/nav.html The latest version of the Material theme seems to have broken our override. Netlify appears to have installed a newer version. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
fix-menu
branch
from
997db5f to
66d626f
Compare
chrisdoherty4
approved these changes
Feb 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update local development to use similar versions that Netlify uses. This helps with troubleshooting/reproducing issues found in Netlify. It appears that some time in August of 2023 that Netlify updated versions of mkdocs and the material theme. This broken our nav override. I was able to fix the nav by copying from: https://github.com/squidfunk/mkdocs-material/blob/master/src/templates/partials/nav.html I don't know that much about HTML or mkdocs so i dont know if this is the proper way to fix this, but it is rendering properly in the Netlify previews.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: