Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

Newer tink for release v0.1.1 / move from Kinvolk -> Tinkerbell repo #25

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

jeremytanner
Copy link
Member

Description

Moves Tinkerbell's Terraform provider from Kinvolk's repo to the Tinkerbell repo, updated the version of the Tink server

Why is this needed

To allow the pid field in templates.

Fixes: #

How Has This Been Tested?

Built and tested new provider

@jeremytanner jeremytanner force-pushed the newer-tink-for-release branch from 5af71da to 5f2e195 Compare July 26, 2021 23:44
@jeremytanner jeremytanner requested a review from displague July 27, 2021 01:44
Copy link
Contributor

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is to allow some fields in templates, shall we have some test for it, so it does not regress? Also, isn't this validation done server side?

@jeremytanner
Copy link
Member Author

Validation comes from the imported https://github.com/tinkerbell/tink (in workflows/types), tests in that repo, will go ahead with 0.1.1 for now

@jeremytanner jeremytanner merged commit bab1eaa into tinkerbell:master Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants