This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
Update to latest sandbox version and remove some workarounds #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateusz Gozdek <[email protected]>
This should no longer be happening with new version of Tinkerbell, so we should return error when this occurs. Signed-off-by: Mateusz Gozdek <[email protected]>
It seems they do not occur when creating anymore. Signed-off-by: Mateusz Gozdek <[email protected]>
invidian
changed the title
|
Once this is merged, I would like to make a release. |
displague
approved these changes
Jan 22, 2021
Yeah, they are most likely pulled together with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as there might be some workarounds which can be now removed.