This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
Improve stability of managing multiple resources in parallel #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes sure that testing configuration generates unique resource names, so multiple outputs can be combined and executed by Terraform in parallel. As a preparation to test mitigations against tinkerbell/tink#338. Signed-off-by: Mateusz Gozdek <[email protected]>
To mitigate tinkerbell/tink#338, as most likely retrying should be happening on server side, not client size. It seems 'database/sql' used by Tink does not export serialization error constant, so we use string matching to check for errors. Checking is strict and should only match only the actual error we want to retry on. Currently, retrying has no limit, as depending on the number of parallel clients, error still may occur. This may potentially lead to the spinlock if deploying with many clients in parallel talking to single Tink server, however, this is not considered for the time being. No retry limit will also ensure, that single client will be able to apply all operations (basically drain the operations "queue"), no matter how many operations are done in parallel. Signed-off-by: Mateusz Gozdek <[email protected]>
invidian
force-pushed
the
invidian/test-parallel-creation
branch
from
695fec7 to
d4e4080
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently due tinkerbell/tink#338, Terraform often return errors if multiple resources are managed in parallel. This PR aims to add some mitigation against that.