This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
tinkerbell: defer client creation to first resource operation #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Terraform was not originally designed to Terraform code feed and configure another provider, if one uses interpolation in provider configuration, which is a legitimate use (e.g. when you create server and deploy Tinkerbell using the same Terraform stack which later on adds hardware entries), client creation will fail, as it is not guaranteed that the fields will be populated on time. This commit defers Tinkerbell client creation to the point where first resource is actually created, which can be ensured with Terraform depends_on option on the resources level. Signed-off-by: Mateusz Gozdek <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Terraform was not originally designed to Terraform code feed and
configure another provider, if one uses interpolation in provider
configuration, which is a legitimate use (e.g. when you create server
and deploy Tinkerbell using the same Terraform stack which later on adds
hardware entries), client creation will fail, as it is not guaranteed
that the fields will be populated on time.
This commit defers Tinkerbell client creation to the point where first
resource is actually created, which can be ensured with Terraform
depends_on option on the resources level.
Signed-off-by: Mateusz Gozdek [email protected]