Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bmclib version: #275

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

jacobweinstock
Copy link
Member

Description

This version has a fix for virtual media ejecting.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This version has a fix for virtual media
ejecting.

Signed-off-by: Jacob Weinstock <[email protected]>
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.80%. Comparing base (8a04fc5) to head (b0e99ba).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   46.80%   46.80%           
=======================================
  Files          11       11           
  Lines        1361     1361           
=======================================
  Hits          637      637           
  Misses        666      666           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jacobweinstock jacobweinstock merged commit 103214c into tinkerbell:main Nov 24, 2024
7 checks passed
@jacobweinstock jacobweinstock deleted the update-bmclib branch November 24, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant