-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intelAMT): add support for HTTPS connections #224
Conversation
Signed-off-by: Léonard Suslian (synthe102) <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 47.96% 47.91% -0.05%
==========================================
Files 11 11
Lines 1080 1081 +1
==========================================
Hits 518 518
- Misses 507 508 +1
Partials 55 55 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @synthe102 ! Just a few code comment changes.
update comment
update comment
update comment
update capitalization
update capitalization
Description
This pull request add support for HTTPS connections with Intel AMT BMCs. Currently
bmclib
useshttp
as a default connection scheme which is not supported on modern AMT platforms (like the Minisforum MS-01 that I used to test this change), and there is no way to set the connection scheme to https with the currentMachine
API.Why is this needed
This is needed to add support for AMT hosts that only support HTTPS connection scheme.
Fixes: #
How Has This Been Tested?
These changes were tested against a Minisforum MS-01 PC that only supports HTTPS AMT. A
Machine
was created that couldn't fetch the powerstate since the authentication would fail because the client would default tohttp
. With these changes,rufio
can successfully interact with the AMT BMC on the computer using https scheme.How are existing users impacted? What migration steps/scripts do we need?
No migration is needed, the new
hostScheme
field defaults tohttp
which keeps the default behavior.Checklist:
I have: