Create a manager cache only when a ns is specified: #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cache with a "" namespace causes reconcile errors: "unable to get: namespace/machine because of unknown namespace for the cache" With this change is the ns is "" we use the default behavior of the manager which is to watch and list all namespaces. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 63.17% 63.17%
=======================================
Files 5 5
Lines 478 478
=======================================
Hits 302 302
Misses 137 137
Partials 39 39 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrisdoherty4
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A cache with a "" namespace causes reconcile errors:
"unable to get: namespace/machine because of unknown namespace for the cache"
With this change if the namespace is
""we use the default behavior of the manager which is to watch and list all namespaces.I believe this was the behavior before we upgrade the controller runtime.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: