Add NMI Support #161
Merged
Add NMI Support #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SendNMI method to the gRPC diagnostic service. The method has also been added to the client. The version of bmclib is updated to use the new SendNMI code. All of the protobuf go files seem to have changed due to minior formatting changes and comments from a newver version of protoc. Signed-off-by: John Mears <[email protected]>
|
At first glance, this looks okay to me |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 82.29% 79.36% -2.94%
==========================================
Files 9 9
Lines 514 533 +19
==========================================
Hits 423 423
- Misses 76 95 +19
Partials 15 15 ☔ View full report in Codecov by Sentry. |
joelrebel
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for issuing an NMI from the BMC, which is helpful for interrupting unresponsive hosts.