Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ipmitool init error Failed to initialize the OEM info dictionary #159

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

joelrebel
Copy link
Collaborator

Description

Its silly that we missed this in the original PR incrementing the ipmitool version, but here we go.

ipmitool fails to start up with the error ipmitool init error Failed to initialize the OEM info dictionary,
this pulls in the fix referenced in the linked issue.

ipmitool/ipmitool#377

Why is this needed

Fixes: #

How Has This Been Tested?

  • Tested locally and on a few machines

How are existing users impacted? What migration steps/scripts do we need?

No impact.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

ipmitool/ipmitool#377

 Please enter the commit message for your changes. Lines starting
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1aa245) 82.29% compared to head (b99edf3) 82.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   82.29%   82.29%           
=======================================
  Files           9        9           
  Lines         514      514           
=======================================
  Hits          423      423           
  Misses         76       76           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelrebel joelrebel merged commit 914dcc1 into tinkerbell:main Feb 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants