Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEL capture support #155

Closed
wants to merge 5 commits into from
Closed

Conversation

mattcburns
Copy link
Contributor

Description

This PR adds in the newly added System Event Log (SEL) capture support added in bmclib.

Note: This updates a previous PR I pulled to remove some duplicate code in my implementation.

How Has This Been Tested?

Tested against a couple of different servers for both opinionated structured and the raw capture methods with success.

How are existing users impacted? What migration steps/scripts do we need?

New methods are available to expose the SEL capture functionality added in bmclib. Two new gRPC endpoints are available:

Diagnostic/GetSystemEventLog - returns an opinionated format of the SEL consisting of a list of id,timestamp,description,message
Diagnostic/GetSystemEventLogRaw - returns a raw dump of the SEL, so that the requestor may parse as they please.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

…d and regenerated protobufs to reflect. Some tests to make codecov happy.

Signed-off-by: Matthew Burns <[email protected]>
Signed-off-by: Matthew Burns <[email protected]>
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (c15e8a7) 81.87% compared to head (6c3d65c) 76.75%.

Files Patch % Lines
grpc/rpc/diagnostic.go 27.45% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   81.87%   76.75%   -5.13%     
==========================================
  Files           9        9              
  Lines         491      542      +51     
==========================================
+ Hits          402      416      +14     
- Misses         75      112      +37     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matthew Burns <[email protected]>
@mattcburns mattcburns closed this Jan 3, 2024
@mattcburns mattcburns deleted the get-systemeventlog branch January 3, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant