Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clear System Event Log support #148

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

mattcburns
Copy link
Contributor

Description

bmclib has clear system event log (SEL) support, add this to pbnj under the diagnostic service.

Why is this needed

Adding functionality supported by bmclib. This will help with cases like clear chassis intrusion alerts.

How Has This Been Tested?

Has been tested against several SuperMicro and Dell devices by checking SEL first, then clearing and checking the SEL was cleared.

How are existing users impacted? What migration steps/scripts do we need?

No impact, other than adding additional features.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #148 (2791f78) into main (c787762) will increase coverage by 0.54%.
The diff coverage is 92.30%.

❗ Current head 2791f78 differs from pull request most recent head 8ec8270. Consider uploading reports for the commit 8ec8270 to get more accurate results

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   81.33%   81.87%   +0.54%     
==========================================
  Files           9        9              
  Lines         466      491      +25     
==========================================
+ Hits          379      402      +23     
- Misses         74       75       +1     
- Partials       13       14       +1     
Files Coverage Δ
grpc/server.go 88.88% <100.00%> (+0.36%) ⬆️
grpc/rpc/diagnostic.go 48.83% <91.30%> (+48.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Oct 16, 2023
@mergify mergify bot merged commit 4bbfd02 into tinkerbell:main Oct 16, 2023
6 checks passed
@mattcburns mattcburns deleted the add-sel-clear-support branch December 7, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants