Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipxedust: add nap.h to arm64 build to set NAP_NULL to support u-boot #152

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

rpardini
Copy link
Contributor

ipxedust: add nap.h to arm64 build to set NAP_NULL to support u-boot

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (52f7e0f) to head (fc5ed25).
Report is 7 commits behind head on main.

❗ Current head fc5ed25 differs from pull request most recent head 3db501c. Consider uploading reports for the commit 3db501c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files           5        5           
  Lines         367      367           
=======================================
  Hits          359      359           
  Misses          4        4           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- see ipxe/ipxe#605 (reply in thread)
- "This will cause iPXE to leave the CPU spinning instead of putting it to sleep, and will avoid the problems on U-Boot."
- Seems harmless on non U-Boot machines -- the CPU will spin during the key timeout (2s?) but that's about it.

Signed-off-by: Ricardo Pardini <[email protected]>
@jacobweinstock jacobweinstock force-pushed the add-arm64-efi-napnull-for-uboot branch from fc5ed25 to 3db501c Compare April 2, 2024 16:11
@jacobweinstock jacobweinstock added the ready-to-merge Mergify: Ready for Merging label Apr 2, 2024
@mergify mergify bot merged commit 9b05492 into tinkerbell:main Apr 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Mergify: Ready for Merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants