Implement workaround to unbreak LetsEncrypt certificates #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obtained via curl -s http://ca.ipxe.org/ca.crt > ca.pem curl -s https://letsencrypt.org/certs/isrgrootx1.pem > isrgrootx1.pem curl -s https://letsencrypt.org/certs/lets-encrypt-r3.pem > lets-encrypt-r3.pem Relates to: tinkerbell#117 Signed-off-by: Nahum Shalman <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 5 5
Lines 442 442
=======================================
Hits 430 430
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. |
nshalman
commented
Dec 13, 2023
Relates to: tinkerbell#117 Signed-off-by: Nahum Shalman <[email protected]>
nshalman
force-pushed
the
letsencrypt-workaround
branch
from
3fa7d2b to
fb650c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per the workaround documented in ipxe/ipxe#606 (comment) we will be embedding some critical LetsEncrypt certificates.
Why is this needed
Relates to: #117, ipxe/ipxe#606
How Has This Been Tested?
I tested resulting binaries against both https://google.com which does not use LetsEncrypt and https://www.shalman.org which does. Both work with this workaround applied.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: