Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI checkout fetch depth 5 in tests #353

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

chrisdoherty4
Copy link
Member

Code coverage requires a fetch depth > 1 to retrieve historical information.

@@ -49,6 +49,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the default 1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir.

jacobweinstock
jacobweinstock previously approved these changes Apr 29, 2024
Code coverage requires a fetch depth > 1 to retrieve historical
information.

Signed-off-by: Chris Doherty <[email protected]>
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.92%. Comparing base (7bb946b) to head (f9152b1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   76.92%   76.92%           
=======================================
  Files          18       18           
  Lines         429      429           
=======================================
  Hits          330      330           
  Misses         87       87           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisdoherty4 chrisdoherty4 merged commit 61a6e5a into tinkerbell:main Apr 29, 2024
11 checks passed
@chrisdoherty4 chrisdoherty4 deleted the hack/ci-checkout branch April 29, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants