Merge pull request #124 from chrisdoherty4/feature/remove-deprecated-…

…options

Remove deprecated CLI args

cmd/hegel/root_cmd.go

@@ -33,19 +33,6 @@ Examples
   --factility              HEGEL_FACILITY
   --http-port              HEGEL_HTTP_PORT
   --http-custom-endpoints  HEGEL_HTTP_CUSTOM_ENDPOINTS
-
-For backwards compatibility a set of deprecated CLI and environment variables are still supported. Behavior for
-specifying both deprecated and current forms is undefined.
-
-Deprecated CLI flags
-  Deprecated   Current
-  --http_port  --http-port
-
-Deprecated environment variables
-  Deprecated          Current
-  CUSTOM_ENDPOINTS    HEGEL_HTTP_CUSTOM_ENDPOINTS
-  DATA_MODEL_VERSION  HEGEL_DATA_MODEL
-  TRUSTED_PROXIES     HEGEL_TRUSTED_PROXIES
 `
 
 // EnvNamePrefix defines the environment variable prefix required for all environment configuration.
@@ -100,10 +87,6 @@ func NewRootCommand() (*RootCommand, error) {
 		return nil, err
 	}
 
-	if err := rootCmd.configureLegacyFlags(); err != nil {
-		return nil, err
-	}
-
 	return rootCmd, nil
 }
 
@@ -194,26 +177,3 @@ func (c *RootCommand) configureFlags() error {
 
 	return err
 }
-
-func (c *RootCommand) configureLegacyFlags() error {
-	c.Flags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName {
-		switch name {
-		case "http_port":
-			return pflag.NormalizedName("http-port")
-		default:
-			return pflag.NormalizedName(name)
-		}
-	})
-
-	for key, envName := range map[string]string{
-		"data-model":            "DATA_MODEL_VERSION",
-		"http-custom-endpoints": "CUSTOM_ENDPOINTS",
-		"trusted-proxies":       "TRUSTED_PROXIES",
-	} {
-		if err := c.vpr.BindEnv(key, envName); err != nil {
-			return err
-		}
-	}
-
-	return nil
-}