Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Only parse gateway if not an empty string: #52

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

jacobweinstock
Copy link
Member

Description

An empty string will cause an error to be returned. As this field is optional, that is not the expected behavior.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

An empty string will cause an error to be returned.
As this field is optional, that is not the expected
behavior.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock added the kind/bug Categorizes issue or PR as related to a bug. label Oct 23, 2023
@jacobweinstock jacobweinstock merged commit 60610e3 into tinkerbell:main Oct 23, 2023
@jacobweinstock jacobweinstock deleted the fix-nil-gw branch October 23, 2023 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant