Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Run code coverage like other Tinkerbell projects #43

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

jacobweinstock
Copy link
Member

Description

I'm seeing weirdness with the current codecov. Non Go files are affecting the coverage reported by codecov. Using the bash script upload instead of the GitHub action.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #43 (138d0ed) into main (9d47c4b) will decrease coverage by 0.41%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 138d0ed differs from pull request most recent head 27bc569. Consider uploading reports for the commit 27bc569 to get more accurate results

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   92.30%   91.89%   -0.41%     
==========================================
  Files          11       11              
  Lines        1052      814     -238     
==========================================
- Hits          971      748     -223     
+ Misses         60       43      -17     
- Partials       21       23       +2     

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobweinstock jacobweinstock merged commit 9226c79 into tinkerbell:main Oct 6, 2023
@jacobweinstock jacobweinstock deleted the dependabot branch October 6, 2023 03:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant