decrease likelihood of possible race condition #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
changed the title
chrisdoherty4
approved these changes
Mar 20, 2023
|
@mergify queue |
🛑 The pull request has been removed from the queuePull request #272 has been dequeued due to failing checks or checks timeout. You can take a look at In case of a failure due to a flaky test, you should first retrigger the CI. |
|
@mergify refresh |
✅ Pull request refreshed |
This gets us the latest and resolves issue with go_install.sh. Signed-off-by: Jacob Weinstock <[email protected]>
This is to avoid a race condition that could occur if a machine is running HookOS and Tink worker is connected and running when a workflow is created. The workflow would start to execute but then be cut off when the reboot action is called. This has been show to cause undefined behavior. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
race-fix
branch
from
1d284b7 to
924f815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to decrease the likelihood of a race condition that could occur if a machine is running HookOS and Tink worker is connected and running when a workflow is created.
The workflow would start to execute but then be cut off when the reboot action is called. This has been shown to cause undefined behavior.
Why is this needed
Fixes:
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: