Enable generic settting of tolerations and affinity for smee deployment #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,9 +108,17 @@ spec: | |||
| {{- if .Values.hostNetwork }} | |||
| hostNetwork: true | |||
| {{- end }} | |||
| {{- if .Values.singleNodeClusterConfig.controlPlaneTolerationsEnabled }} | |||
| {{- if or .Values.deployment.tolerations .Values.singleNodeClusterConfig.controlPlaneTolerationsEnabled }} | |||
There was a problem hiding this comment.
I would be OK with replacing the controlPlaneTolerationsEnabeld entirely in favor of complete customization.
Signed-off-by: Willem Monsuwe <[email protected]>
jacobweinstock
force-pushed
the
smee-custom-tolerations
branch
from
8db79dc to
777437e
Compare
jacobweinstock
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Thanks, @willemm . @chrisdoherty4, we can come back to this if we want to change anything up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds generic
tolerationsandaffinityfields to the valuesWhy is this needed
This way, users have more control over where the smee pod is running.
We have a setup where a specific node is added to the management-cluster, which is in the same L2 network as the machines that are being provisioned (as is required by dhcp).
(Before this we had a separate vm running in the target network, running smee with extra configurations so that it can grab the required configurations from the management cluster externally, but that setup is way more complicated, having to put serviceaccount tokens in there and everything)
How Has This Been Tested?
With this new chart setup, added specific tolerations and affinity that target a taint/label on the 'special' node which is in the target network. After that, provisioned some machines which worked fine.
How are existing users impacted? What migration steps/scripts do we need?
Shouldn't impact anyone in any way.
However, this would open the door to removing the singleNodeClusterConfig code and just documenting how these settings can be used on a single node cluster.
Checklist:
I have: