Update image2disk #139
Merged
Update image2disk #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
force-pushed
the
image2disk-update
branch
from
707a961 to
6bfeb09
Compare
It was reported that EOF errors were causing image2disk to fail. This improves the EOF handling so that streaming doesn't fail. Retry logic is added to mitigate misbehaving network stacks and file servers. Signed-off-by: Jacob Weinstock <[email protected]>
Update the Go dependencies as much as possible. github.com/containerd/containerd and github.com/deislabs/oras were not updated as oras depends on containerd and the latest oras lib is very different and would be significant work to refactor oci2disk. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
image2disk-update
branch
from
f0c4d73 to
dce1243
Compare
The following envs were added as opt in: RETRY_ENABLED RETRY_DURATION_MINUTES PROGRESS_INTERVAL_SECONDS TEXT_LOGGING Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
image2disk-update
branch
from
dce1243 to
dbeb92e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates image2disk to improve EOF handling. This also adds retry logic to the whole image2disk process.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: