Refactor multi arch builds #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single runner has some downsides. It takes a long time. Individual actions cannot be rerun on failure. Signed-off-by: Jacob Weinstock <[email protected]>
The grub-bios package doesn't exist on arm64. This fixes the builds by not installing grub-bios on arm64. I don't know if this will be an issue with the functionality of grub2disk on arm64. I will need to test. Signed-off-by: Jacob Weinstock <[email protected]>
This will improve debug-ability and retries. Signed-off-by: Jacob Weinstock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is attempting to improve the time it takes to build both architectures and splits each image into its own GitHub actions job so that failures can be retried independently.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: