Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic CI #120

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Add basic CI #120

merged 1 commit into from
Mar 12, 2024

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Mar 11, 2024

Follows #119

Add a basic CI that builds images for every branch and builds and pushes images with every merge to main. The revision is used as tags for all images and all images are built and pushed with every merge irrespective of the files changed.

We aren't trying to build an optimized a CI or introduce a release process. We're adding checks that don't already exist and pushing images frequently for consumption. We will organically evolve the CI to optimize builds and how we decide what gets built.

Side note: the CI passed first time 😄 https://github.com/tinkerbell/actions/actions/runs/8225760871/job/22491237138?pr=120

@chrisdoherty4 chrisdoherty4 changed the title Remove individual action go.mod files Add basic CI Mar 11, 2024
@chrisdoherty4 chrisdoherty4 force-pushed the hack/ci branch 2 times, most recently from d6bdc81 to 4c09bee Compare March 11, 2024 12:56
@chrisdoherty4 chrisdoherty4 marked this pull request as ready for review March 11, 2024 12:56
@chrisdoherty4 chrisdoherty4 force-pushed the hack/ci branch 2 times, most recently from cb71e2f to a334ab8 Compare March 11, 2024 13:06
Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chrisdoherty4.

Makefile Outdated Show resolved Hide resolved
The CI builds and pushes Linux amd64 images to quay.io tagged using
the full commit revision.

Signed-off-by: Chris Doherty <[email protected]>
@chrisdoherty4 chrisdoherty4 merged commit c9fcb3f into tinkerbell:main Mar 12, 2024
3 checks passed
@chrisdoherty4 chrisdoherty4 deleted the hack/ci branch March 12, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants