Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to create lvm in the partition command #101

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

walkerus
Copy link
Contributor

Description

Adding the ability to create LVM in the partition command by adding the volume_groups object to the metadata

Why is this needed

#36

Fixes: #

How Has This Been Tested?

I tested the changes on Dell PowerEdge R650 and Lenovo ThinkSystem SR630 V2 servers with the standard hook kernel.
I ran the action rootio with the partition command and added lvm-related data to the metadata. After creating the logical volumes, I initialized the file systems on them using the rootio format command.
Changes do not affect the current code if you do not add lvm-related parameters to the metadata.

To start using the changes, just add an optional array describing volume groups to the metadata

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

* use 100%FREE vg space if get 0b for lv

Signed-off-by: walkerus <[email protected]>
@walkerus walkerus requested a review from displague October 23, 2023 20:46
@chrisdoherty4 chrisdoherty4 added the ready-to-merge Signal to Mergify to merge the PR. label Jan 19, 2024
@chrisdoherty4 chrisdoherty4 merged commit 0cf4266 into tinkerbell:main Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants