Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACCT-1931] feat(test): adding account check collection for us #1

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

TruptiShrimant
Copy link
Contributor

Adding a postman collection specific for testing US account check with continuous access.

@TruptiShrimant TruptiShrimant requested a review from a team as a code owner December 29, 2023 10:58
@TruptiShrimant TruptiShrimant force-pushed the ACCT-1931-US-AC-PostmanCollection branch from 2b4eb5c to cd1a6f7 Compare January 3, 2024 10:10
@TruptiShrimant TruptiShrimant force-pushed the ACCT-1931-US-AC-PostmanCollection branch 2 times, most recently from 73e9c5d to 8ad2d24 Compare January 11, 2024 12:36
},
{
"key": "tink_link",
"value": "https://link.us.tink.com/1.0/account-check/connect?client_id=ae89c638d52444bfbea050a6cd773d29&state=OPTIONAL&redirect_uri=https%3A%2F%2Fconsole.us.tink.com%2Fcallback&authorization_code=9b24a6ac05004ee8bab57b12ee42b7d3&market=US&test=true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the URL and remove any ids or codes and replace it with {{...}} like the values listed above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this one, I don't think we have &test=true applicable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I've modified the url.

"let redirectUriEncoded = encodeURIComponent(redirectUri);",
"",
"//Compose TinkLink URI",
"let tinkLink = \"https://link.us.tink.com/1.0/account-check/connect?client_id=YOUR_CLIENT_ID&state=OPTIONAL&redirect_uri=REDIRECT_URL&authorization_code=USER_AUTHORIZATION_CODE&market=MARKET&test=TEST\"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&test=TEST, Is this something that actually works? I thought we had removed this from being applicable. We decide if it is a test or not by setting it in the console to be either sandbox or live

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@TruptiShrimant TruptiShrimant force-pushed the ACCT-1931-US-AC-PostmanCollection branch from 8ad2d24 to bf55a66 Compare January 11, 2024 14:15
@TruptiShrimant TruptiShrimant force-pushed the ACCT-1931-US-AC-PostmanCollection branch from bf55a66 to 6163ef9 Compare January 11, 2024 15:16
@TruptiShrimant TruptiShrimant merged commit a0f3f91 into master Jan 11, 2024
5 checks passed
@TruptiShrimant TruptiShrimant deleted the ACCT-1931-US-AC-PostmanCollection branch January 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants