This repository has been archived by the owner on Aug 7, 2020. It is now read-only.
support for phantomjs running #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some synchronization issues with phantomjs, these were fixed in HtmlUnitBasedScriptInstrumenter.java and ScriptData.java
I also added better support for jasmine-maven-plugin if it was executed with phantomjs.
If you use jasmine with phatnomjs it runs the tests through a webserver, and saga also
used this server to calculate coverage. Because of this, total coverage report was not possible,
since it saw only the files tested by jasmine.
To solve this, I expanded FileSystemSourcePreloader.java. If sourceDirs is defined in pom.xml, then it is used as full source directory.