Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Class Method for ICAO Codes #135

Closed
wants to merge 1 commit into from
Closed

Add Class Method for ICAO Codes #135

wants to merge 1 commit into from

Conversation

FinnLawrence
Copy link
Contributor

Changes

  • Add new icao_codes class method to return ICAO codes for airports, equivalent with Aiports.iata_codes.
  • Add spec for new method.

timrogers
timrogers approved these changes Nov 29, 2024
View reviewed changes
Copy link
Owner

@timrogers timrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻 Can you merge in the latest changes from main so we can get the tests passing, and then I'll release this?

@timrogers timrogers mentioned this pull request Nov 29, 2024
Merged
@timrogers
Copy link
Owner

I handled this in #138 to make things faster!

@timrogers timrogers closed this Nov 29, 2024
@FinnLawrence FinnLawrence deleted the icao-codes branch November 30, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timrogers timrogers timrogers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FinnLawrence @timrogers