-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct docstrings - warnings & errors #301
Open
fdhoff
wants to merge
47
commits into
timotheus:master
Choose a base branch
from
fdhoff:foster/docstrings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 38bb259.
Added str conversion of siteid
encode utf-8 on string object only
replace 'basestring' with 'str'
Add an option for domain to sample/findings.py so it can work with sandbox keys
Make compatible with python 3
updated trading sample
Revert "Make compatible with python 3"
Python3 compatibility
…ding api class base_list_nodes
added 'getmyebaysellingresponse.activelist.itemarray.item' to base_list_nodes
I tested this by commenting those lines out in the site-packages, (on Anaconda on Windows). Everything seems to work fine; if you import parallel after importing other ebaysdk packages, though, you get a "monkey patch" warning message. Regardless of whether you import it before or after, basic things seem to work fine with Parallel on python 3; I haven't tested everything though.
Allow parallel support in python 3
Allow parallel support for python 3
Set Finding API to use https by default
update samples with param: 'domain'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes only affect docstrings. I had been trying to figure out how to disable warnings when I stumbled into the
warnings
anderrors
configuration options. Only then did I notice the docstrings were incorrect and missing information.