Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authentication element fix #179

Merged
merged 1 commit into from
May 3, 2024
Merged

authentication element fix #179

merged 1 commit into from
May 3, 2024

Conversation

webbsledge
Copy link
Contributor

Automatic authentication was failing because the TDA authentication page element ID names have changed. This small change updates the authentication IDs in the code to correct for the current ID names.

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.71%. Comparing base (728b9a0) to head (0a2a7f2).
Report is 2 commits behind head on main.

Files Patch % Lines
tdameritrade/auth/__init__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   76.71%   76.71%           
=======================================
  Files          27       27           
  Lines        1091     1091           
  Branches      110      110           
=======================================
  Hits          837      837           
  Misses        239      239           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timkpaine timkpaine merged commit 417400e into timkpaine:main May 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants