Feature/add vggface2 labels #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #60 |
DavidKatz-il
suggested changes
Oct 14, 2020
| def load_labels(self, pretrained): | ||
| if pretrained is not 'vggface2': | ||
| return None | ||
| with open(os.path.join(os.path.dirname(__file__), f'../data/labels-vggface2.csv')) as f: |
There was a problem hiding this comment.
f-string is supported only from python>=3.6, Travis CI also runs on python 3.5
So if you want to use f-string you need to drop python 3.5 from CI, and also updateing setup.py.
|
@timesler @DavidKatz-il are there any plans to add this? It would be really useful, since as-is, the Keras VGGFace implementation has this functionality, but facenet does not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.