Refactor batch segment metadata builder for bloom filters #7597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan to implement bloom filter sparse indexes for compressed data, so the compressed batch metadata builder requires some cosmetic changes to support other types of metadata.
|
@gayyappan, @fabriziomello: please review this pull request.
|
akuzm
commented
Jan 16, 2025
| @@ -0,0 +1,184 @@ | |||
|
|
|||
There was a problem hiding this comment.
These files were just renamed, git doesn't detect it because there were also many renames inside.
svenklemm
approved these changes
Jan 16, 2025
antekresic
approved these changes
Jan 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7597 +/- ##
==========================================
+ Coverage 80.06% 82.31% +2.24%
==========================================
Files 190 238 +48
Lines 37181 44146 +6965
Branches 9450 11097 +1647
==========================================
+ Hits 29770 36338 +6568
- Misses 2997 3431 +434
+ Partials 4414 4377 -37 ☔ View full report in Codecov by Sentry. |
svenklemm
pushed a commit
to pallavisontakke/timescaledb
that referenced
this pull request
Jan 23, 2025
…7597) We plan to implement bloom filter sparse indexes for compressed data, so the compressed batch metadata builder requires some cosmetic changes to support other types of metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to implement bloom filter sparse indexes for compressed data, so the compressed batch metadata builder requires some cosmetic changes to support other types of metadata.
Disable-check: force-changelog-file