-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong origin returned by cagg_get_bucket_function_info #7533
Fix wrong origin returned by cagg_get_bucket_function_info #7533
Conversation
443d35b
to
9270501
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7533 +/- ##
==========================================
+ Coverage 80.06% 82.19% +2.12%
==========================================
Files 190 230 +40
Lines 37181 43280 +6099
Branches 9450 10882 +1432
==========================================
+ Hits 29770 35574 +5804
- Misses 2997 3390 +393
+ Partials 4414 4316 -98 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, left a question about readability and setting the right expectations in the code.
9270501
to
1b66597
Compare
In timescale#7042 we refactored the code for getting the time bucket function info to read information from the stored query tree on Postgres metadata. But when an origin was not specified it was returning a wrong value instead of NULL. Fixed it by properly dealing with non-defined origin and also simplified a bit the code to process time bucket parameters.
1b66597
to
172bc86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some old odd choices regarding the time_bucket
function implementation, but the changes here are good.
Automated backport to 2.17.x not done: cherry-pick failed. Git status
|
In #7042 we refactored the code for getting the time bucket function info to read information from the stored query tree on Postgres metadata.
But when an origin was not specified it was returning a wrong value instead of NULL. Fixed it by properly dealing with non-defined origin and also simplified a bit the code to process time bucket parameters.
Disable-check: force-changelog-file