Fix compiler error when using PG_TRY..PG_FINALLY #7530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In timescale#7505 we used PG_TRY() .. PG_FINALLY() but some CI configurations was not happy with it reporting "variable might be clobbered by longjmp". Fixed it by using PG_TRY() .. PG_CATCH() instead. https://github.com/timescale/timescaledb/actions/runs/12277548387/job/34257269473#step:13:206
fabriziomello
added
bug
continuous_aggregate
ci
disable-auto-backport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7530 +/- ##
==========================================
+ Coverage 80.06% 82.15% +2.09%
==========================================
Files 190 230 +40
Lines 37181 43252 +6071
Branches 9450 10875 +1425
==========================================
+ Hits 29770 35535 +5765
- Misses 2997 3393 +396
+ Partials 4414 4324 -90 ☔ View full report in Codecov by Sentry. |
akuzm
approved these changes
Dec 12, 2024
mkindahl
approved these changes
Dec 12, 2024
|
@fabriziomello I'm going to merge this to unblock the CI for some PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7505 we used PG_TRY() .. PG_FINALLY() but some CI configurations was not happy with it reporting "variable might be clobbered by longjmp".
Fixed it by using PG_TRY() .. PG_CATCH() instead.
https://github.com/timescale/timescaledb/actions/runs/12277548387/job/34257269473#step:13:206
Disable-check: force-changelog-file