Allow mentioning fixed issues in the changelog #6542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antekresic, @konskov: please review this pull request.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6542 +/- ##
==========================================
+ Coverage 79.69% 79.73% +0.04%
==========================================
Files 188 188
Lines 36781 36825 +44
Branches 9310 9310
==========================================
+ Hits 29311 29361 +50
- Misses 3116 3123 +7
+ Partials 4354 4341 -13 ☔ View full report in Codecov by Sentry. |
When time_bucket is compared to constant in WHERE, we also add condition on the underlying time variable (ts_transform_time_bucket_comparison). Unfortunately we only do this for plan-time constants, which prevents chunk exclusion when the interval is given by a query parameter, and a generic plan is used. This commit also tries to apply this optimization after applying the execution-time constants. This PR also enables startup exclusion based on parameterized filters.
Also allow mentioning the PR like now. The numbers of issues must match the issues referenced by the PR.
|
Snuck it into #6505 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allow mentioning the PR like now. The numbers of issues must match the issues referenced by the PR.