Refactor image introspection and tagging #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now directly pass the builder and release IDs to the subsequent steps instead of depending on the names. We were accidentally using the previous builder when we were determining versions to come up with tag names. This also adds a step to remove some of the contents of the github runner installations to make more room for building. /mnt has a lot of space but since we're doing all the work in docker, the root filesystem was sometimes filling up.
graveland
force-pushed
the
brent/fix_tag_race
branch
from
784dd6a to
e5e1f9f
Compare
alexeyklyukin
approved these changes
Oct 14, 2024
JamesGuthrie
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now directly pass the builder and release IDs to the subsequent steps instead of depending on the names. We were accidentally using the previous builder when we were determining versions to come up with tag names.
This also adds a step to remove some of the contents of the github runner installations to make more room for building. /mnt has a lot of space but since we're doing all the work in docker, the root filesystem was sometimes filling up.
We also drop a docker install for arm images since the non-beta arm runners already include it now.