Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: install all dependencies through just pgai install #325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: install all dependencies through just pgai install #325

wants to merge 1 commit into from

Conversation

smoya
Copy link
Contributor

@smoya smoya commented Dec 20, 2024

  • Updated the just pgai install to include the --all-extras flag.
  • Modified the command for installing dependencies in GH actions to use just pgai install.

@smoya smoya requested a review from a team as a code owner December 20, 2024 11:10
@smoya smoya requested review from alejandrodnm and Askir December 20, 2024 11:11
JamesGuthrie
JamesGuthrie reviewed Dec 20, 2024
View reviewed changes
projects/pgai/justfile
@@ -25,7 +25,7 @@ build:

# Install the wheel package locally
install:
@uv sync
@uv sync --all-extras
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if this is strictly correct, but AFAICT we don't have any optional dependencies at the moment anyway, so it's kind of moot.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesGuthrie we do need them, otherwise sqlachemy won't be installed, and you'll get an error when running tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah, I see now. I had missed that we now do have an optional dependency.

@alejandrodnm
Copy link
Contributor

alejandrodnm commented Dec 20, 2024 •
edited
Loading

@smoya should we add just pgai install here? Or maybe have it as a dependency of just pgai test or just pgai ci?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrodnm alejandrodnm alejandrodnm approved these changes

@JamesGuthrie JamesGuthrie JamesGuthrie approved these changes

@Askir Askir Awaiting requested review from Askir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoya @alejandrodnm @JamesGuthrie