Code for evaluating open source embedding models #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askir
reviewed
Dec 17, 2024
examples/finding_best_open_source_embedding_model/best_embedding_model_rag_app.ipynb
Outdated
Show resolved
Hide resolved
examples/finding_best_open_source_embedding_model/best_embedding_model_rag_app.ipynb
Outdated
Show resolved
Hide resolved
examples/finding_best_open_source_embedding_model/best_embedding_model_rag_app.ipynb
Outdated
Show resolved
Hide resolved
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "with connect_db() as conn:\n", |
There was a problem hiding this comment.
Instead of loading the data from a csv file (and leaving the user to figure that out), try this:
SELECT ai.load_dataset('sgoel9/paul_graham_essays', table_name => 'essays');
There was a problem hiding this comment.
Addendum:
SELECT ai.load_dataset('sgoel9/paul_graham_essays', table_name => 'essays', if_table_exists => 'append');
There was a problem hiding this comment.
👍 for using this but this then also needs pgai 0.6.0 not 0.5.0
There was a problem hiding this comment.
I actually couldn't find the function when using pgai 0.6.0 yesterday. @JamesGuthrie
examples/finding_best_open_source_embedding_model/best_embedding_model_rag_app.ipynb
Outdated
Show resolved
Hide resolved
…ng_model_rag_app.ipynb Co-authored-by: James Guthrie <[email protected]> Signed-off-by: Hervé Ishimwe <[email protected]>
Askir
reviewed
Dec 18, 2024
examples/finding_best_open_source_embedding_model/best_embedding_model_rag_app.ipynb
Show resolved
Hide resolved
examples/finding_best_open_source_embedding_model/best_embedding_model_rag_app.ipynb
Outdated
Show resolved
Hide resolved
Askir
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
sweet, thanks for incorporating all the feedback
The ci pipeline complains because we use conventional commits btw: https://www.conventionalcommits.org/en/v1.0.0/
You might wanna change your commit message to be in line as well as the PR title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the code for the blog post about finding the best open-source embedding model. Please start with the Jupyter notebook for explanations on how to run the code.
Thank you for the review!