Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify 'destination' argument #262

Merged
merged 6 commits into from
Dec 19, 2024
Merged

docs: clarify 'destination' argument #262

merged 6 commits into from
Dec 19, 2024

Conversation

smoya
Copy link
Contributor

@smoya smoya commented Nov 28, 2024

I believe we must clarify a bit what the destination field is used for and how VS target_table and view_name, the more granular options.

Open to suggestions, this can taken as the starting point of a discussion.

@smoya smoya requested a review from a team as a code owner November 28, 2024 11:19
docs/vectorizer-api-reference.md Outdated Show resolved Hide resolved
docs/vectorizer-api-reference.md Outdated Show resolved Hide resolved
docs/vectorizer-api-reference.md Outdated Show resolved Hide resolved
Copy link
Contributor

@billy-the-fish billy-the-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments to put the argument name in code and a description update. Looks good.

docs/vectorizer-api-reference.md Outdated Show resolved Hide resolved
docs/vectorizer-api-reference.md Outdated Show resolved Hide resolved
@smoya smoya force-pushed the docs/clarifyDestination branch from 2909a19 to b1927b4 Compare December 19, 2024 10:37
@smoya smoya merged commit 39fcf93 into main Dec 19, 2024
5 checks passed
@smoya smoya deleted the docs/clarifyDestination branch December 19, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants