chore: use snapshot tests #228
Conversation
JamesGuthrie
force-pushed
the
jg/use-snapshot-tests
branch
5 times, most recently
from
51550bd to
ec32a46
Compare
Uses `syrupy` to handle snapshotting of text outputs. To update the snapshot files, run `pytest --snapshot-update` or `just test-update`.
JamesGuthrie
force-pushed
the
jg/use-snapshot-tests
branch
from
ec32a46 to
7020ddd
Compare
There was a problem hiding this comment.
I'm not crazy about this change. I like that it reduces code, however it feels like a worse experience.
There's no typing or even an import statement to clue somebody into what snapshot is or how it's supposed to work. You have to know to go look at syrupy and learn how it works. Previously, there was more code, but it was straightforward.
The actual output isn't stored anywhere on disk where I can look at it easily with whatever tool I wish.
Correct me if I'm wrong, but just test-update is all-or-nothing. When dealing with changes that trigger these test failures, I prefer to run each in isolation and carefully fix each one at a time. There's less mental load that way.
| text=True, | ||
| capture_output=True, | ||
| ) | ||
| return result.stdout |
There was a problem hiding this comment.
| return result.stdout | |
| return str(result.stdout) |
and change the function's return type to str
| text=True, | ||
| capture_output=True, | ||
| ) | ||
| return result.stdout |
There was a problem hiding this comment.
| return result.stdout | |
| return str(result.stdout) |
and change the return type to str
No description provided.