Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof-of-concept work to identify & fix sources of logging loops #753

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

rfortier
Copy link
Contributor

@rfortier rfortier commented Dec 3, 2024

(log messages that repeat forever).

For discussion. Would never propose merging such ugly hacks.

@rfortier
Copy link
Contributor Author

rfortier commented Dec 3, 2024

I run with debug console typically, and typically after a few hours of playing the logging loops are so bad the game slows down. So I went after the problem.

The bulk of the logs that loop and don't go away are caused by AppliedQueuedEffects and related routines. These "queue" effects until conditions are met like actors being fully created, or assigned a server ID. But the problem is they never give up; they try and log endlessly. If you are a magic user (I usually am), the build up over time until the game is unplayable.

… messages that repeat forever).

For discussion. Would never propose merging such ugly hacks.
@rfortier rfortier force-pushed the fix/excess-logging-bugs branch from c470d10 to 6a9e2d2 Compare December 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants