fix(helm_resource): no parallel in helm_repo

Multiple invocations of `helm_repo` may not be concurrency safe because of the execution of `helm repo add`. This commit unsets the `allow_parallel` argument in `helm_repo` to prevent this bug. Resolves #500 Signed-off-by: Nick Schmeller <[email protected]>
tilt-dev · May 25, 2023 · fe7713b · fe7713b
1 parent 1328004
commit fe7713b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/helm_resource/Tiltfile b/helm_resource/Tiltfile
@@ -155,4 +155,4 @@ def helm_repo(
   if password:
     args.extend(['--password', password])
 
-  local_resource(resource_name, args, allow_parallel=True, **kwargs)
+  local_resource(resource_name, args, allow_parallel=False, **kwargs)
diff --git a/helm_resource/test/Tiltfile b/helm_resource/test/Tiltfile
@@ -98,3 +98,12 @@ helm_resource(
   labels=['memcached'],
   resource_deps=['helm-repo-bitnami'],
   auto_init=False)
+
+helm_repo(name='vm-charts',
+          url='https://victoriametrics.github.io/helm-charts')
+helm_repo(name='grafana-charts',
+          url='https://grafana.github.io/helm-charts')
+helm_resource(name='grafana',
+              chart='grafana-charts/grafana',
+              flags=['--values', './dev/grafana/values.yaml'],
+              port_forwards=[3000])