Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextpnr flag '--exit-on-failed-target-frequency' #294

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

jthornblad
Copy link
Contributor

Description

  • Add flag so we can keep nextpnr standard behavior and if this flag is used we can get a fast exit if timing fails on placement.

  • Update run_pnr.sh script to use this flag

Type of change

Please tick any that are relevant to this PR and remove any that aren't.

  • Bugfix (non breaking change which resolve an issue)
  • Feature (non breaking change which adds functionality)
  • Breaking Change (a change which would cause existing functionality to not work as expected)
  • Documentation (a change to documentation)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)
  • QEMU is updated to reflect changes

@dehanj

This comment was marked as outdated.

@jthornblad jthornblad force-pushed the add_nextpnr_exit_on_fail_freq_flag branch from 399415d to 5d94e75 Compare November 15, 2024 09:24
@jthornblad jthornblad force-pushed the add_nextpnr_exit_on_fail_freq_flag branch from 5d94e75 to e4c2d72 Compare November 22, 2024 13:38
@dehanj dehanj force-pushed the add_nextpnr_exit_on_fail_freq_flag branch from e4c2d72 to 0445c8f Compare November 22, 2024 14:49
Copy link
Member

@dehanj dehanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on main. Works fine.
Now when our sed insert starts to be more complicated it starts to make more sense to have a fork. It might be easier to maintain.

@dehanj dehanj merged commit 0445c8f into main Nov 22, 2024
5 checks passed
@dehanj dehanj deleted the add_nextpnr_exit_on_fail_freq_flag branch November 22, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants