Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate entries in default values assignment of tk1 api #293

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Remove duplicate entries in default values assignment of tk1 api #293

merged 1 commit into from
Nov 13, 2024

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Nov 13, 2024 •
edited
Loading

Description

cpu_mon_en_we and cdi_mem_we was set twice in the tk1 api
This does not change the digest of the bitstream, so it is most likely removed during the build process.

Fixes # (issues)

Type of change

  • Bugfix (non breaking change which resolve an issue)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing

@dehanj
Remove duplicate entries in default values assignment of tk1 api
b90bbea 
cpu_mon_en_we and cdi_mem_we was set twice
@dehanj dehanj marked this pull request as ready for review November 13, 2024 12:45
@dehanj dehanj merged commit b90bbea into main Nov 13, 2024
5 checks passed
@dehanj dehanj deleted the remove_duplicates branch November 13, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthornblad jthornblad jthornblad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dehanj @jthornblad