Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize the naming of Firmware/App mode. #285

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Harmonize the naming of Firmware/App mode. #285

merged 1 commit into from
Nov 12, 2024
+149 −146

Conversation

jthornblad
Copy link
Contributor

Description

Harmonize the naming of Firmware/App mode.

Type of change

Please tick any that are relevant to this PR and remove any that aren't.

  • Bugfix (non breaking change which resolve an issue)
  • Feature (non breaking change which adds functionality)
  • Breaking Change (a change which would cause existing functionality to not work as expected)
  • Documentation (a change to documentation)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)
  • QEMU is updated to reflect changes

@dehanj dehanj force-pushed the harmonize_mode_naming branch 2 times, most recently from baba4a1 to ffff9cb Compare November 12, 2024 12:45
@dehanj dehanj force-pushed the harmonize_mode_naming branch 5 times, most recently from 4bcea24 to fecaac7 Compare November 12, 2024 14:06
dehanj
dehanj approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@dehanj dehanj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

I have:

  • Formated the code
  • Ran testfw and tkey-device-signer
  • Added deprecation notice in tk1_mem.h, and kept the old define to not break any apps right away.
  • Ran testbenches
  • Ran linting
  • Updated application_fpga digest

@jthornblad @dehanj
Harmonize the naming of firmware and app mode.
aea2e31 
- The API changes name from `_SWITCH_APP` to `_SYSTEM_MODE_CTRL`.
- The registers and wires changes name to `system_mode_*`, instead of a
  mix of `switch_app_*` and `fw_app_mode`.
@dehanj dehanj merged commit aea2e31 into main Nov 12, 2024
5 checks passed
@dehanj dehanj deleted the harmonize_mode_naming branch November 12, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehanj dehanj dehanj approved these changes

@agren agren Awaiting requested review from agren

@mchack-work mchack-work Awaiting requested review from mchack-work

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jthornblad @dehanj